Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reports for originals and topleft #57

Merged
merged 11 commits into from
Aug 8, 2023
Merged

Add reports for originals and topleft #57

merged 11 commits into from
Aug 8, 2023

Conversation

seakayone
Copy link
Collaborator

No description provided.

@codacy-production
Copy link

codacy-production bot commented Aug 4, 2023 •
edited
Loading

Coverage summary from Codacy

Merging #57 (60cded2) into main (876c206) - See PR on Codacy

Coverage variation Diff coverage
❌ -2.64% (target: -1.00%) 35.96%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (876c206) 723 348 48.13%
Head commit (60cded2) 798 (+75) 363 (+15) 45.49% (-2.64%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#57) 114 41 35.96%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@seakayone seakayone requested review from BalduinLandolt and mpro7 and removed request for BalduinLandolt August 4, 2023 15:38
@seakayone seakayone self-assigned this Aug 7, 2023
BalduinLandolt
BalduinLandolt approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I added two minor stylistic remarks, feel free to ignore them

src/main/scala/swiss/dasch/api/MaintenanceEndpointRoutes.scala Outdated Show resolved Hide resolved
src/main/scala/swiss/dasch/domain/Asset.scala Show resolved Hide resolved
mpro7
mpro7 approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@mpro7 mpro7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 argument name change suggestions, where the type already defines that shortcode is String, so no need IMO repeating it.

src/main/scala/swiss/dasch/api/MaintenanceEndpointRoutes.scala Outdated Show resolved Hide resolved
src/main/scala/swiss/dasch/domain/ProjectService.scala Outdated Show resolved Hide resolved
@seakayone seakayone merged commit d7dd990 into main Aug 8, 2023
6 of 7 checks passed
@seakayone seakayone deleted the add-reports-for-originals-and-topleft branch August 8, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

@mpro7 mpro7 mpro7 approved these changes

Assignees

@seakayone seakayone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seakayone @mpro7 @BalduinLandolt